Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove several deprecated values, especially result-related #968

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

raphael-proust
Copy link
Collaborator

This PR removes some long-deprecated functions. Mostly those related to the result type.

@raphael-proust raphael-proust force-pushed the remove-some-long-deprecated-functions branch 2 times, most recently from bdfd092 to 84d008e Compare October 24, 2022 14:48
@raphael-proust raphael-proust force-pushed the remove-some-long-deprecated-functions branch from 84d008e to 2bc4fbd Compare February 2, 2023 16:07
@raphael-proust
Copy link
Collaborator Author

I don't feel strongly about whether this PR should be merged. It could break some packages (which will need new constraints). OTOH these functions have been deprecated for a while.

Opinions?

@MisterDA
Copy link
Contributor

MisterDA commented Feb 3, 2023

Regarding Lwt.result, it seems a good idea to use Stdlib.Result for all cases. Less of a burden to have this type not duplicated.

@raphael-proust raphael-proust merged commit a8122b7 into master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants